Rollback increase timeout for deactivating failpoint #18022
Conversation
|
Hi @henrybear327. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ahrtr when gofail 0.2.0 is released, I will update the gofail dependencies in another PR and rebase this one on top of it! Currently, this PR serves as double-checking the CI is still working normally after the recent gofail final changes are merged before releasing the new tag! Update: using the new gofail commit, the CI passes normally, and rolling back the change so far looks fine! |
|
Pending PR etcd-io/gofail#69 to bump gofail to 0.2.0 (etcd-io/gofail#65 (comment)) |
henrybear327
force-pushed
the
pr/rollback_17719
branch
from
787e926
to
0caea1b
Compare
|
/ok-to-test |
Because of etcd-io/gofail#64 being merged, we can rollback the change. Reference: - etcd-io#17719 Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
henrybear327
force-pushed
the
pr/rollback_17719
branch
from
0caea1b
to
637cdb2
Compare
|
Don't think we need to block in integration tests |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Completed via #17680. |
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
Because etcd-io/gofail#64 is merged, we can roll back the change.
Reference: